timeline: refactor reaction handling #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meta's reaction fields to the Reactions object No changes in functionality, pure code motion.
It's exactly the same as `Reaction::senders`'s length.
… or remote id This makes it impossible to represent states like "there's a local *and* a remote echo for the same sender for a given reaction", or multiple reactions from the same sender to the same event, and so on.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3761 +/- ##
==========================================
- Coverage 84.08% 84.08% -0.01%
==========================================
Files 260 259 -1
Lines 27031 26993 -38
==========================================
- Hits 22730 22697 -33
+ Misses 4301 4296 -5 ☔ View full report in Codecov by Sentry. |
bnjbvr
force-pushed
the
bnjbvr/refactor-reactions
branch
from
8a8a581 to
d234324
Compare
stefanceriu
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves fields around, renames stuff, and changes the way we store reactions:
Reactions::mapand storing reactions inEventTimelineItemas two sources of truth, reactions are only stored inEventTimelineItemnow. There's still the need to map from a reaction txn-id | event-id to the thing it's reacting to (e.g. when redacting a reaction), somaphas been adapted for that usage.Reactions::map.annotation keythen bysender id, instead ofannotation keythentxn id | event id. This has the benefit of making it impossible to have two reactions from the same sender. I'm wondering if that could cause issue with local vs remote reactions from the current user, so will ask for further testing.This should be reviewable commit by commit.