crypto: Store device_id in SenderData #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
approved these changes
Jul 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3769 +/- ##
=======================================
Coverage 84.06% 84.07%
=======================================
Files 259 259
Lines 27059 27061 +2
=======================================
+ Hits 22748 22752 +4
+ Misses 4311 4309 -2 ☔ View full report in Codecov by Sentry. |
andybalaam
commented
Jul 26, 2024
andybalaam
force-pushed
the
andybalaam/device-id-in-senderknown
branch
from
7d3e49d to
1e468ee
Compare
This means we have all the information inside SenderData to populate VerificationStatus and DeviceId for EncryptionInfo, so we can share the code between SenderDataFinder and get_verification_state.
andybalaam
force-pushed
the
andybalaam/device-id-in-senderknown
branch
from
1e468ee to
04cde92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we have all the information inside SenderData to populate VerificationStatus and DeviceId for EncryptionInfo, so we can share the code between SenderDataFinder and get_verification_state.
Part of #3751