Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: refactor beacon_info tests into their own folder #3794

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

torrybr
Copy link
Contributor

@torrybr torrybr commented Aug 1, 2024

Move the beacon_info tests to their own folder to accommodate the addition of several more future test cases.

Signed-off-by: Torry Brelsford [email protected]

@torrybr torrybr requested a review from a team as a code owner August 1, 2024 22:10
@torrybr torrybr requested review from stefanceriu and removed request for a team August 1, 2024 22:10
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.08%. Comparing base (d7224a7) to head (d3025b3).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3794      +/-   ##
==========================================
- Coverage   84.09%   84.08%   -0.01%     
==========================================
  Files         259      259              
  Lines       27089    27089              
==========================================
- Hits        22780    22778       -2     
- Misses       4309     4311       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, looks good to me but I do wonder if a new beacon_info module was necessary on this level as opposed to bundling it with the existing beacon one (which is also using beacon_info).

Also, please fix the sign off.

@torrybr
Copy link
Contributor Author

torrybr commented Aug 2, 2024

Your choice on the preferred approach 👍 I can refactor to combine under beacon if you want but they are 2 separate event types in the spec if that makes any difference

@stefanceriu
Copy link
Member

Okay, fair point, let's keep them separate then 👍

@stefanceriu stefanceriu merged commit be6bc44 into matrix-org:main Aug 2, 2024
40 checks passed
@torrybr torrybr mentioned this pull request Sep 9, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants