crypto: Update SenderData on /keys/query response
#3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
andyrich/sender-data-from-keys-query
branch
5 times, most recently
from
b40fefe to
d785bb8
Compare
richvdh
force-pushed
the
rav/update_on_keys_query
branch
from
b1e0aca to
92950d7
Compare
richvdh
force-pushed
the
andyrich/sender-data-from-keys-query
branch
2 times, most recently
from
99f672e to
7929242
Compare
richvdh
force-pushed
the
rav/update_on_keys_query
branch
2 times, most recently
from
be0b80f to
c332fa2
Compare
richvdh
changed the title
/keys/query response/keys/query response
richvdh
requested review from
stefanceriu and
andybalaam
and removed request for
a team
richvdh
changed the base branch from
andyrich/sender-data-from-keys-query
to
main
richvdh
force-pushed
the
rav/update_on_keys_query
branch
from
c332fa2 to
09e77a4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3849 +/- ##
==========================================
- Coverage 84.16% 84.15% -0.01%
==========================================
Files 267 267
Lines 28107 28140 +33
==========================================
+ Hits 23656 23681 +25
- Misses 4451 4459 +8 ☔ View full report in Codecov by Sentry. |
richvdh
force-pushed
the
rav/update_on_keys_query
branch
3 times, most recently
from
3befbec to
0e295aa
Compare
bnjbvr
changed the title
/keys/query response/keys/query response
andybalaam
requested changes
Sep 3, 2024
crates/matrix-sdk-crypto/src/machine/tests/megolm_sender_data.rs
Outdated
Show resolved
Hide resolved
We need write access to this in the integration tests
If the previous session is removed from the list, we should still be able to continue iterating through the *rest* of the list.
This module has a number of useful types (in particular, error types). Rather than addding even more types to the top level module, let's export the `sender_data_finder` module as a whole.
When we receive an `/keys/query` response, look for existing inboundgroupsessions created by updated devices, and see if we can update any of their senderdata settings.
Extend the integration tests for megolm sender data to check that we update existing inbound group sessions when we get a `/keys/query` response.
richvdh
force-pushed
the
rav/update_on_keys_query
branch
from
edfc611 to
dbc852b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3753
Builds on #3806, #3920, #3921