-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MatrixRTC: Fix different devices from the same user overwriting the room info state event. #3972
Conversation
The commit history does not conform to guidelines. I suspect a rebase will be required anyways which contains the switch to the ruma/ruma. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3972 +/- ##
=======================================
Coverage 84.27% 84.27%
=======================================
Files 266 266
Lines 28336 28337 +1
=======================================
+ Hits 23880 23881 +1
Misses 4456 4456 ☔ View full report in Codecov by Sentry. |
3f20c3b
to
c97cde0
Compare
c97cde0
to
2602849
Compare
Tarpaulin is failing. Is this sth that I can fix? |
No, intermittent failure. Do you have the permissions to restart it by yourself in the CI interface? (I'll restart it now for you) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, thanks for these changes!
Tiny feedback.
e2fc856
to
79c93ac
Compare
…oom info state event.
79c93ac
to
77b416c
Compare
The ruma PR that changes this got merged, so I updated this PR to use the updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the PR on Ruma!
This PR is best reviewed with the background from: #3998
The main change in this PR is the transition from using a UserId as the index for call member events in the room info to using the newly introduced
CallMemberStateKey
that is a combination of UserId and device id.This is important since otherwise the room state could only store one event per user (but a user can join with multiple devices)
It also adds tests for session membership events (which is the new state event format for call member state events we need for reliable state events)
Signed-off-by: