Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi: expose method to allow user account deactivate for m.login.password based accounts #4002

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

stefanceriu
Copy link
Member

Expose the Account method but restrict it to the types we were already using for user interactive authorization on the identity reset flows.

@stefanceriu stefanceriu requested a review from a team as a code owner September 16, 2024 11:37
@stefanceriu stefanceriu requested review from Hywan and removed request for a team September 16, 2024 11:37
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I would prefer to have a test with the erase_data, it seems pretty important to test :-].

crates/matrix-sdk/src/account.rs Show resolved Hide resolved
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (aa92e26) to head (3e242ce).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4002      +/-   ##
==========================================
+ Coverage   84.27%   84.30%   +0.02%     
==========================================
  Files         266      266              
  Lines       28315    28315              
==========================================
+ Hits        23863    23870       +7     
+ Misses       4452     4445       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… is supported

- i.e. only works for `m.login.password`
@stefanceriu stefanceriu force-pushed the stefan/account_deactivation branch from 3e242ce to 6cd4023 Compare September 16, 2024 12:15
@stefanceriu stefanceriu requested a review from Hywan September 16, 2024 13:33
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we are good now :-]. Thanks for the test!

crates/matrix-sdk/tests/integration/account.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/tests/integration/account.rs Outdated Show resolved Hide resolved
@stefanceriu stefanceriu force-pushed the stefan/account_deactivation branch from e414149 to 1640b85 Compare September 16, 2024 14:29
@stefanceriu stefanceriu merged commit a1bb7c0 into main Sep 16, 2024
36 of 38 checks passed
@stefanceriu stefanceriu deleted the stefan/account_deactivation branch September 16, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants