-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffi: expose method to allow user account deactivate for m.login.password
based accounts
#4002
Conversation
…word` based accounts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although I would prefer to have a test with the erase_data
, it seems pretty important to test :-].
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4002 +/- ##
==========================================
+ Coverage 84.27% 84.30% +0.02%
==========================================
Files 266 266
Lines 28315 28315
==========================================
+ Hits 23863 23870 +7
+ Misses 4452 4445 -7 ☔ View full report in Codecov by Sentry. |
… is supported - i.e. only works for `m.login.password`
3e242ce
to
6cd4023
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we are good now :-]. Thanks for the test!
e414149
to
1640b85
Compare
Expose the Account method but restrict it to the types we were already using for user interactive authorization on the identity reset flows.