Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: increase timeout duration when awaiting a timeline update #4005

Merged

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Sep 16, 2024

Fixes #3931, or so I think: the test waits for a stable state where there aren't any new updates to the timeline, before trying to edit a timeline item, and observe a precise sequence of timeline updates after the item has been edited.

The failures showed that the stable state wasn't reached, because in some occasions, we'd receive the original text as a new timeline update — which could also be the sign of a failing server / duplicated event or other things, but I believe it is just that 1 second timeouts ain't enough for code running under CodeCov.

@bnjbvr bnjbvr requested a review from a team as a code owner September 16, 2024 13:50
@bnjbvr bnjbvr requested review from andybalaam and removed request for a team September 16, 2024 13:50
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.24%. Comparing base (abbe2ec) to head (19400fc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4005      +/-   ##
==========================================
- Coverage   84.25%   84.24%   -0.01%     
==========================================
  Files         266      266              
  Lines       28328    28328              
==========================================
- Hits        23867    23865       -2     
- Misses       4461     4463       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree: we could easily see some kind of system slowdown that takes longer than 1 second, so this change is good even if it doesn't fix the problem.

@bnjbvr bnjbvr merged commit ea9da3b into main Sep 16, 2024
40 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/increase-tiemout-when-waiting-for-timeline-updates branch September 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests::timeline::test_stale_local_echo_time_abort_edit intermittently fails
2 participants