feat(base): Increase the room_info_notable_update_sender capacity
#4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
approved these changes
Sep 17, 2024
bnjbvr
approved these changes
Sep 17, 2024
Hywan
force-pushed
the
fix-ui-room-list-detect-lag-from-roominfonotableupdate
branch
3 times, most recently
from
fe00c61 to
d3feae7
Compare
|
I've removed the comments as suggested by @bnjbvr and I've used |
stefanceriu
approved these changes
Sep 17, 2024
bnjbvr
reviewed
Sep 17, 2024
Comment on lines
232
to
236
| Err(RecvError::Closed) => { | ||
| error!("Cannot receive room info notable updates because the sender has been closed"); | ||
| } |
There was a problem hiding this comment.
hacktualley: if this stream has closed, then this infinite loop will iloop on this case, right? Maybe we should return at this point?
There was a problem hiding this comment.
I'm adding a little break then. Good catch. It would have been caught previously, but not anymore.
This patch updates `merge_stream_and_receiver` to display an `error!` when the room info receiver reads an error, like `Closed` or `Lagged`. This is helpful when debugging.
This broadcast channel can easily be overflowed if more than 100 updates arrive at the time. This patch extends the capacity to 2^16 - 1.
Hywan
force-pushed
the
fix-ui-room-list-detect-lag-from-roominfonotableupdate
branch
from
d3feae7 to
f00bbf8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4013 +/- ##
==========================================
- Coverage 84.27% 84.24% -0.04%
==========================================
Files 266 266
Lines 28336 28343 +7
==========================================
- Hits 23880 23877 -3
- Misses 4456 4466 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broadcast channel can easily be overflowed if more than 100 updates arrive
at the time. This patch extends the capacity to 2^16 - 1.
This patch also adds more logs to detect lagged on this channel from the room
list point of view.