refactor(event cache): simplify the locking situation #4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ood todo list All the items have their equivalent sub item in the issue anyways.
…ble state This limits the possibility of race conditions in users of this API.
…ture It only contained two fields, and it avoids one extra level of cognitive overhead and makes the type hierarchy flatter.
… pagination tokens
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4115 +/- ##
==========================================
+ Coverage 84.67% 84.69% +0.02%
==========================================
Files 269 269
Lines 28816 28822 +6
==========================================
+ Hits 24401 24412 +11
+ Misses 4415 4410 -5 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Oct 15, 2024
| None => PaginationToken::HitEnd, | ||
| }; | ||
| { | ||
| let mut tokens = self.tokens.lock().unwrap(); |
There was a problem hiding this comment.
I have a deja-vu, didn't I suggest a single lock for this a month or two ago? Anyways, nice that we remove some locks.
There was a problem hiding this comment.
Yes, that rings a bell, sorry I hadn't listened more 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the locking situation, in particular it would've made the bug fixed by #3501 impossible to happen in the first place (or at least, way more obvious).
Fixes #3502. Thanks @Hywan for the technical discussion we had about it.