chore: Enable the default features for futures-util #4120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We depend on the `futures_util::steam_select` macro since 9b36a04. This macro requires the async-await-macros and std feature of futures-util. These features are the default features so let's just stop disabling the default features for futures-util.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4120 +/- ##
==========================================
+ Coverage 84.67% 84.69% +0.01%
==========================================
Files 269 269
Lines 28816 28816
==========================================
+ Hits 24401 24406 +5
+ Misses 4415 4410 -5 ☔ View full report in Codecov by Sentry. |
jplatte
approved these changes
Oct 12, 2024
Co-authored-by: Jonas Platte <[email protected]> Signed-off-by: Damir Jelić <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We depend on the
futures_util::steam_selectmacro since 9b36a04. This macro requires the async-await-macros and std feature of futures-util.These features are the default features so let's just stop disabling the default features for futures-util.