refactor(oidc): allow passing a Prompt to get an OIDC url
#4131
Conversation
jmartinesp
force-pushed
the
misc/add-oidc-prompt-parameter-for-url-for-oidc-login
branch
from
3294bd0 to
2386ff2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4131 +/- ##
==========================================
- Coverage 84.72% 84.62% -0.11%
==========================================
Files 269 269
Lines 28837 28831 -6
==========================================
- Hits 24432 24398 -34
- Misses 4405 4433 +28 ☔ View full report in Codecov by Sentry. |
Changelog: `Client::url_for_oidc_login` is now `Client::url_for_oidc` with an additional `OidcPrompt` parameter. `abort_oidc_login` has been renamed to `abort_oidc_auth`. This allows clients to directly open the web page they want: the login one, the registration one, consent, etc. It should improve the UX in the registration flow since we can now skip the login one.
jmartinesp
force-pushed
the
misc/add-oidc-prompt-parameter-for-url-for-oidc-login
branch
from
1959558 to
a83a630
Compare
| Unknown { value: String }, | ||
| } | ||
|
|
||
| impl From<OidcPrompt> for SdkOidcPrompt { |
There was a problem hiding this comment.
Consider annotating the SdkOidcPrompt with the uniffi derive in place of adding the wrapper, since the wrapper seems completely equivalent?
There was a problem hiding this comment.
Prompt comes from an external crate, so I think there's no way to export it? Also, the enum uses the Case(value) form, which is not allowed by uniffi 🫤 .
There was a problem hiding this comment.
oh i see, so SdkOidcPrompt is a preexisting dubious name, but oh well. Nevermind me :)
There was a problem hiding this comment.
It's true the name makes you think the type comes from the SDK... I can rename it to something better in another PR, but nothing came to mind. OAuth2OidcPrompt? Should I just use the full oauth2types::requests::Prompt form?
There was a problem hiding this comment.
Do not fret too much about it, sorry, this was more a light remark at the existing code. But yeah using the fully-qualified type would look great here!
bnjbvr
deleted the
misc/add-oidc-prompt-parameter-for-url-for-oidc-login
branch
This allows clients to directly open the web page they want: the login one, the registration one, consent, etc. It should improve the UX in the registration flow since we can now skip the login one.
Requested in element-hq/element-x-android#3635.
Signed-off-by: