Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(contributing): Recommend --interactive for git rebase --autosquash #4133

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

andybalaam
Copy link
Member

Older versions of Git require --interactive when we supply --autosquash, and it's also probably a good idea generally.

See https://stackoverflow.com/a/77663575/22610 for more info.

Older versions of Git require --interactive when we supply --autosquash,
and it's also probably a good idea generally.

See https://stackoverflow.com/a/77663575/22610 for more info.
@andybalaam andybalaam requested a review from a team as a code owner October 16, 2024 09:23
@andybalaam andybalaam requested review from poljar and removed request for a team October 16, 2024 09:23
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that's why it autosquash didn't work for some people without --interactive mode.

People don't update their software 😢

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (3d04234) to head (8dc42d7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4133      +/-   ##
==========================================
+ Coverage   84.69%   84.71%   +0.01%     
==========================================
  Files         269      269              
  Lines       28770    28770              
==========================================
+ Hits        24367    24372       +5     
+ Misses       4403     4398       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andybalaam andybalaam merged commit efc2e2c into main Oct 16, 2024
40 checks passed
@andybalaam andybalaam deleted the andybalaam/document-rebase-interactive branch October 16, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants