Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in contributing guide #4136

Merged
merged 1 commit into from
Oct 16, 2024
Merged

doc: fix typo in contributing guide #4136

merged 1 commit into from
Oct 16, 2024

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Oct 16, 2024

The convention is for changelog entries to be in the imperative, not the past
tense.

The convention is for changelog entries to be in the imperative, not the past
tense.
@richvdh richvdh requested a review from a team as a code owner October 16, 2024 11:18
@richvdh richvdh requested review from bnjbvr and removed request for a team October 16, 2024 11:18
@richvdh richvdh mentioned this pull request Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (efc2e2c) to head (b60750b).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4136      +/-   ##
==========================================
+ Coverage   84.69%   84.70%   +0.01%     
==========================================
  Files         269      269              
  Lines       28770    28770              
==========================================
+ Hits        24366    24371       +5     
+ Misses       4404     4399       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar merged commit 2829b07 into main Oct 16, 2024
40 checks passed
@poljar poljar deleted the rav/fix_contributing_typo branch October 16, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants