Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ffi): don't panic when joining after having cancelled a media upload #4141

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Oct 16, 2024

Fixes #3573.

@bnjbvr bnjbvr requested a review from a team as a code owner October 16, 2024 15:48
@bnjbvr bnjbvr requested review from andybalaam and removed request for a team October 16, 2024 15:48
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (30f3a3c) to head (a66772b).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4141      +/-   ##
==========================================
- Coverage   84.72%   84.71%   -0.02%     
==========================================
  Files         269      269              
  Lines       28779    28779              
==========================================
- Hits        24384    24380       -4     
- Misses       4395     4399       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can disallow unwraps in the ffi crate.

@bnjbvr bnjbvr requested review from stefanceriu and removed request for andybalaam October 16, 2024 16:18
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this isn't panicking anymore and that it still works propoperly. Will follow up though with a change on the iOS side to get rid of that extra cancellation call

@bnjbvr bnjbvr merged commit a901506 into main Oct 16, 2024
40 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/fix-media-upload-panic branch October 16, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ffi: cancelling media upload results in panic
3 participants