Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(knocking): Add reason and server_names to Client::knock #4150

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

jmartinesp
Copy link
Contributor

These are needed parts of the API 😬 .

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@jmartinesp jmartinesp requested a review from a team as a code owner October 17, 2024 15:51
@jmartinesp jmartinesp requested review from bnjbvr and removed request for a team October 17, 2024 15:51
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (f2f99fb) to head (cab394b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4150      +/-   ##
==========================================
+ Coverage   84.82%   84.84%   +0.02%     
==========================================
  Files         269      269              
  Lines       28862    28862              
==========================================
+ Hits        24482    24489       +7     
+ Misses       4380     4373       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp marked this pull request as draft October 17, 2024 16:06
@jmartinesp jmartinesp marked this pull request as ready for review October 18, 2024 10:11
@jmartinesp
Copy link
Contributor Author

Set it back to ready for review after double-checking it's the API we need.

Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment on lines 2252 to 2254
let mut request = knock_room::v3::Request::new(room_id_or_alias);
request.reason = reason;
request.via = server_names;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

light suggestion: prefer using assign!:

Suggested change
let mut request = knock_room::v3::Request::new(room_id_or_alias);
request.reason = reason;
request.via = server_names;
let request = assign!(knock_room::v3::Request::new(room_id_or_alias), { reason, via: server_names });

@jmartinesp jmartinesp force-pushed the chore/add-reason-and-via-to-knocking branch from 1fc3ea7 to cab394b Compare October 22, 2024 15:28
@jmartinesp jmartinesp merged commit 3f5d54c into main Oct 22, 2024
40 checks passed
@jmartinesp jmartinesp deleted the chore/add-reason-and-via-to-knocking branch October 22, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants