Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Upgrade Ruma to 0.11.0 #4171

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Oct 27, 2024

The version that was just published on crates.io.

@zecakeh zecakeh requested review from a team as code owners October 27, 2024 13:25
@zecakeh zecakeh requested review from jmartinesp and andybalaam and removed request for a team October 27, 2024 13:25
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.79%. Comparing base (40f4fc1) to head (af0259d).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
...rates/matrix-sdk-crypto/src/types/one_time_keys.rs 0.00% 6 Missing ⚠️
crates/matrix-sdk-crypto/src/backups/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4171      +/-   ##
==========================================
+ Coverage   84.77%   84.79%   +0.02%     
==========================================
  Files         269      269              
  Lines       28963    28969       +6     
==========================================
+ Hits        24552    24563      +11     
+ Misses       4411     4406       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cargo.toml Outdated Show resolved Hide resolved
@andybalaam andybalaam requested review from poljar and removed request for andybalaam October 28, 2024 10:00
@andybalaam
Copy link
Member

Nominate @poljar - I don't feel qualified to review this. Damir, feel free to send me some other review in exchange :-)

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, let's just remove the unsigned Curve25519 key handling, we don't use it.

@zecakeh
Copy link
Collaborator Author

zecakeh commented Oct 29, 2024

I realized that since the Ruma types are reexported, this is actually a breaking change so the conventional commit should reflect that.

@poljar
Copy link
Contributor

poljar commented Oct 29, 2024

I realized that since the Ruma types are reexported, this is actually a breaking change so the conventional commit should reflect that.

Alright, feel free to rewrite the history. The PR looks good.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh
Copy link
Collaborator Author

zecakeh commented Oct 29, 2024

Commit history cleaned up and commit message changed.

@zecakeh zecakeh changed the title chore: Upgrade Ruma to 0.11.0 refactor!: Upgrade Ruma to 0.11.0 Oct 29, 2024
@poljar poljar merged commit 5158b39 into matrix-org:main Oct 30, 2024
41 checks passed
@zecakeh zecakeh deleted the upgrade-ruma branch October 30, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants