-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Upgrade Ruma to 0.11.0 #4171
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4171 +/- ##
==========================================
+ Coverage 84.77% 84.79% +0.02%
==========================================
Files 269 269
Lines 28963 28969 +6
==========================================
+ Hits 24552 24563 +11
+ Misses 4411 4406 -5 ☔ View full report in Codecov by Sentry. |
Nominate @poljar - I don't feel qualified to review this. Damir, feel free to send me some other review in exchange :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, let's just remove the unsigned Curve25519 key handling, we don't use it.
I realized that since the Ruma types are reexported, this is actually a breaking change so the conventional commit should reflect that. |
Alright, feel free to rewrite the history. The PR looks good. |
Signed-off-by: Kévin Commaille <[email protected]>
Commit history cleaned up and commit message changed. |
The version that was just published on crates.io.