Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event cache store): add ability to rename a media cache key #4177

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Oct 28, 2024

What it says on the tin. Will allow caching medias before they're sent to a remote, when used with the send queue.

Part of #1732.

@bnjbvr bnjbvr requested a review from a team as a code owner October 28, 2024 15:41
@bnjbvr bnjbvr requested review from jmartinesp and removed request for a team October 28, 2024 15:41
Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very clean PR, thanks.

@bnjbvr bnjbvr enabled auto-merge (rebase) October 28, 2024 15:53
@bnjbvr bnjbvr force-pushed the bnjbvr/media-cache-rename-realz branch from b245a90 to c2c00f0 Compare October 29, 2024 17:00
@bnjbvr bnjbvr merged commit be88e0a into main Oct 29, 2024
40 checks passed
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (ee80291) to head (c2c00f0).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4177      +/-   ##
==========================================
- Coverage   84.86%   84.86%   -0.01%     
==========================================
  Files         270      270              
  Lines       29031    29066      +35     
==========================================
+ Hits        24637    24666      +29     
- Misses       4394     4400       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr deleted the bnjbvr/media-cache-rename-realz branch October 29, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants