-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(send queue): send attachments with the send queue #4195
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4195 +/- ##
==========================================
- Coverage 84.87% 84.82% -0.06%
==========================================
Files 272 273 +1
Lines 29251 29519 +268
==========================================
+ Hits 24828 25040 +212
- Misses 4423 4479 +56 ☔ View full report in Codecov by Sentry. |
19e5936
to
3cbf449
Compare
cfb6039
to
51d85b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a pair-review via Element Call. I'm approving this PR, it's an excellent code. @bnjbvr has taken notes for things that are left to do, but nothing blocking the merge.
Impressive PR. Well done!
13d5de4
to
08ba679
Compare
…tings` Changelog: all the fields of `MediaThumbnailSize` have been inlined into `MediaThumbnailSettings`, and the former type has been removed.
Because it's not a request we send to the server; it's some of the request parameters.
38d9612
to
d1c34b5
Compare
Fixes #1732. This adds support for sending medias via the send queue, which gives us local echoes for free.
The process looks like this:
The send queue dependency system is made such that, a dependent request depends on at most one other request. The design chosen in this PR is that dependencies are kept linear, each request depends on the previous one to be finished. As such, it means that when uploading a thumbnail, we need to remember the thumbnail MXC ID when uploading the file, because the file request will pass that information (when it's completed) to the media event.
This can not be reviewed commit by commit. Instead, I'd recommend looking at the commit which improves the module doc comment first: 1d0ba02
And then review the rest of the changes; we can also have a call to do the review together.
Sits on top of #4199 and #4200.