task(tests): introduce prebuilt mocks and mocking helpers #4197

bnjbvr · 2024-10-31T13:30:10Z

This introduces new test utilities, starting with MatrixMockServer. This is a pair of a MockServer and a Client (one can retrieve them respectively with .server() and .client()).

It implements a few mock endpoints, expanding and limited the shared code as much as possible, so the mocks are still flexible to use as scoped/unscoped mounts, named, and so on.

It works like this:

start with telling which endpoint you'd like to mock, e.g. mock_room_send(). This returns a specialized MockSomething data structure, with its own impl. For this example, it's MockRoomSend.
configure the response on the endpoint-specific mock data structure. For instance, if you want the sending to result in a transient failure, call MockRoomSend::error500(); if you want it to succeed and return the event $42, call MockRoomSend::ok(event_id!("$42")). It's still possible to call respond_with(), as we do with wiremock MockBuilder, for maximum flexibility when the helpers aren't sufficient.
once the endpoint's response is configured, for any mock builder, you get a MatrixMock; this is a plain wiremock::Mock with the server curried, so one doesn't have to pass it around when calling .mount() or .mount_as_scoped(). As such, it mostly defers its implementations to wiremock::Mock under the hood.

Example

With this, we can go from that code:

#[async_test]
async fn test_make_reply_event_doesnt_require_event_cache() {
    let (client, server) = logged_in_client_with_server().await;

    let event_id = event_id!("$1");
    let resp_event_id = event_id!("$resp");
    let room_id = room_id!("!galette:saucisse.bzh");

    let f = EventFactory::new();

    let raw_original_event = f
        .text_msg("hi")
        .event_id(event_id)
        .sender(client.user_id().unwrap())
        .room(room_id)
        .into_raw_timeline();

    mock_sync_with_new_room(
        |builder| {
            builder.add_joined_room(JoinedRoomBuilder::new(room_id));
        },
        &client,
        &server,
        room_id,
    )
    .await;

    Mock::given(method("GET"))
        .and(path_regex(r"^/_matrix/client/r0/rooms/.*/event/"))
        .and(header("authorization", "Bearer 1234"))
        .respond_with(ResponseTemplate::new(200).set_body_json(raw_original_event.json()))
        .expect(1)
        .named("/event")
        .mount(&server)
        .await;

    let new_content = RoomMessageEventContentWithoutRelation::text_plain("uh i mean bonjour");

    let room = client.get_room(room_id).unwrap();

    // make_edit_event works, even if the event cache hasn't been enabled.
    room.make_edit_event(resp_event_id, EditedContent::RoomMessage(new_content)).await.unwrap();
}

To that code:

#[async_test]
async fn test_make_reply_event_doesnt_require_event_cache() {
    let mock = MatrixMockServer::new().await;
    let user_id = mock.client().user_id().unwrap().to_owned();

    let room_id = room_id!("!galette:saucisse.bzh");
    let room = mock.sync_joined_room(room_id).await;

    let event_id = event_id!("$1");
    let f = EventFactory::new();
    mock.mock_room_event()
        .ok(f.text_msg("hi").event_id(event_id).sender(&user_id).room(room_id).into_timeline())
        .expect(1)
        .named("/event")
        .mount()
        .await;

    let new_content = RoomMessageEventContentWithoutRelation::text_plain("uh i mean bonjour");

    // make_edit_event works, even if the event cache hasn't been enabled.
    room.make_edit_event(event_id, EditedContent::RoomMessage(new_content)).await.unwrap();
}

codecov · 2024-10-31T13:46:32Z

Codecov Report

Attention: Patch coverage is 94.59459% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5d83808). Learn more about missing BASE report.
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/matrix-sdk/src/test_utils/mocks.rs	94.48%	8 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4197   +/-   ##
=======================================
  Coverage        ?   84.90%           
=======================================
  Files           ?      274           
  Lines           ?    29677           
  Branches        ?        0           
=======================================
  Hits            ?    25196           
  Misses          ?     4481           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andybalaam

This is great. Passing on to @richvdh because a) I think he will have helpful feedback and b) I'm not available next week.