Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: start an architecture document with a high-level description of the crates #4198

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Oct 31, 2024

Based on reading the https://matklad.github.io/2021/02/06/ARCHITECTURE.md.html blog post, @andybalaam and I started an architecture document explaining at a high-level what the different crates are. We hope to also include the most important high-level components in the mix, as a vague map of where things are implemented. (e.g. Timeline, SyncService, RoomListService, etc.). Very WIP-y, etc.

@bnjbvr bnjbvr marked this pull request as ready for review November 7, 2024 16:50
@bnjbvr bnjbvr requested a review from a team as a code owner November 7, 2024 16:50
@bnjbvr bnjbvr requested review from stefanceriu and removed request for a team November 7, 2024 16:50
@bnjbvr bnjbvr changed the title WIP: start an architecture document with a high-level description of the crates doc: start an architecture document with a high-level description of the crates Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.93%. Comparing base (75683d2) to head (d690fc9).
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4198      +/-   ##
==========================================
+ Coverage   84.88%   84.93%   +0.04%     
==========================================
  Files         272      272              
  Lines       29131    29131              
==========================================
+ Hits        24729    24741      +12     
+ Misses       4402     4390      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for setting this up!

@stefanceriu stefanceriu merged commit 26bee1c into main Nov 8, 2024
50 of 76 checks passed
@stefanceriu stefanceriu deleted the bnjbvr/architecture-md branch November 8, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants