-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and clean up our ambiguity handling #4218
Conversation
fe8868b
to
4c376a1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4218 +/- ##
==========================================
+ Coverage 84.83% 84.85% +0.01%
==========================================
Files 273 273
Lines 29525 29530 +5
==========================================
+ Hits 25048 25057 +9
+ Misses 4477 4473 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
4532a4d
to
3932a26
Compare
The ambiguity map tracks the users which are using a single display name, so let's reflect that in the name.
…ay name disambiguation
3932a26
to
b89c409
Compare
This is in preparation of some higher level user display name handling, thus the rename of our
DisplayName
type as well.No functional changes here.