Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and clean up our ambiguity handling #4218

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Nov 5, 2024

This is in preparation of some higher level user display name handling, thus the rename of our DisplayName type as well.

No functional changes here.

@poljar poljar requested a review from a team as a code owner November 5, 2024 15:22
@poljar poljar requested review from jmartinesp and removed request for a team November 5, 2024 15:22
@poljar poljar force-pushed the poljar/refactor-ambiguity-handling branch from fe8868b to 4c376a1 Compare November 5, 2024 15:34
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.85%. Comparing base (237419c) to head (b89c409).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk-base/src/rooms/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4218      +/-   ##
==========================================
+ Coverage   84.83%   84.85%   +0.01%     
==========================================
  Files         273      273              
  Lines       29525    29530       +5     
==========================================
+ Hits        25048    25057       +9     
+ Misses       4477     4473       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

crates/matrix-sdk-base/src/store/ambiguity_map.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-base/src/store/ambiguity_map.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-base/src/store/ambiguity_map.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-base/src/store/ambiguity_map.rs Outdated Show resolved Hide resolved
@bnjbvr bnjbvr removed the request for review from jmartinesp November 5, 2024 16:59
@poljar poljar force-pushed the poljar/refactor-ambiguity-handling branch from 4532a4d to 3932a26 Compare November 7, 2024 15:13
@poljar poljar force-pushed the poljar/refactor-ambiguity-handling branch from 3932a26 to b89c409 Compare November 7, 2024 15:20
@poljar poljar merged commit 5d83808 into main Nov 7, 2024
40 checks passed
@poljar poljar deleted the poljar/refactor-ambiguity-handling branch November 7, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants