feat(media): replace MediaThumbnailSettings default ctor with reasonable defaults
#4225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4225 +/- ##
=======================================
Coverage 84.83% 84.84%
=======================================
Files 273 273
Lines 29519 29519
=======================================
+ Hits 25042 25044 +2
+ Misses 4477 4475 -2 ☔ View full report in Codecov by Sentry. |
jplatte
reviewed
Nov 6, 2024
Comment on lines
77
to
78
| "mxc://send-queue.localhost/{}", | ||
| txn_id |
There was a problem hiding this comment.
Suggested change
| "mxc://send-queue.localhost/{}", | |
| txn_id | |
| "mxc://send-queue.localhost/{txn_id}", |
jplatte
approved these changes
Nov 6, 2024
…only taking a width and height This one is used when caching a thumbnail everywhere, and when attempting to retrieve it; it gives us a single place where to coordinate the default `MediaThumbnailSettings` parameters.
bnjbvr
force-pushed
the
bnjbvr/reasonable-media-request-default
branch
from
2be9622 to
ea8745d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new ctor is used when caching a thumbnail everywhere, and when
attempting to retrieve it; it gives us a single place where to
coordinate the default
MediaThumbnailSettingsparameters.