refactor!(send queue): move RoomSendQueue::unwedge to the SendHandle type
#4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4226 +/- ##
==========================================
+ Coverage 84.83% 84.85% +0.02%
==========================================
Files 273 273
Lines 29519 29522 +3
==========================================
+ Hits 25042 25052 +10
+ Misses 4477 4470 -7 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Nov 11, 2024
| /// | ||
| /// * `transaction_id` - The send queue transaction identifier of the local | ||
| /// echo that should be unwedged. | ||
| pub async fn try_resend(&self, transaction_id: String) -> Result<(), ClientError> { |
There was a problem hiding this comment.
This method is totally removed. Is it intentional?
There was a problem hiding this comment.
It's moved to SendHandle::try_resend() :)
Comment on lines
+1695
to
+1696
| // TODO(bnjbvr): remove this, once we have settled the `SendHandle` vs `SendAttachmentHandle` | ||
| // situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This better encapsulates the transaction id of the send handle. Also introduced a FFI method to retrieve the
SendHandleof a timeline local echo.Let's see how hard it becomes in practice for EX apps, cc @jmartinesp @stefanceriu.
Part of #4201