fix(event cache): give looser parameters for the deduplicator's bloom filters #4231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
approved these changes
Nov 7, 2024
poljar
approved these changes
Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4231 +/- ##
=======================================
Coverage 84.82% 84.82%
=======================================
Files 273 273
Lines 29519 29519
=======================================
Hits 25039 25039
Misses 4480 4480 ☔ View full report in Codecov by Sentry. |
… filters The previous values would lead to super large memory allocations, as observed with `valgrind --tool=massive` on the tiny test added in this commit: - for 400 rooms each having 100 events, this led to 540MB of allocations. - for 1000 rooms each having 100 events, this led to 1.5GB of allocations. This is not acceptable for any kind of devices, especially for mobile devices which may be more constrained on memory. The bloom filter is an optimisation to avoid going through events in the room's event list, so it shouldn't cause a big toll like that; instead, we can reduce the parameters values given when creating the filters. With the given parameters, 1000 rooms each having 100 events leads to 1.2MB of allocations.
bnjbvr
force-pushed
the
bnjbvr/lower-bloom-filter-heuristics
branch
from
962c18c to
8d49a90
Compare
|
Oh, nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous values would lead to super large memory allocations, as observed with
valgrind --tool=massiveon the tiny test added in this commit:This is not acceptable for any kind of devices, especially for mobile devices which may be more constrained on memory. The bloom filter is an optimisation to avoid going through events in the room's event list, so it shouldn't cause a big toll like that; instead, we can reduce the parameters values given when creating the filters.
With the given parameters, 1000 rooms each having 100 events leads to 1.2MB of allocations.