refactor(ffi): Make is_room_alias_format_valid stricter
#4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
changed the title
is_room_alias_format_valid more strictis_room_alias_format_valid stricter
Previously this only used the Ruma checks, which only handled the initial `#` char and the domain part. With these changes, the name part is also validated, checking it's lowercase, with no whitespaces and containing only allowed chars, similar to what `DisplayName::to_room_alias_name` does. Moved the code to the SDK crate so it can be properly tested.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4234 +/- ##
==========================================
+ Coverage 84.87% 84.91% +0.04%
==========================================
Files 274 274
Lines 29677 29689 +12
==========================================
+ Hits 25187 25211 +24
+ Misses 4490 4478 -12 ☔ View full report in Codecov by Sentry. |
jmartinesp
force-pushed
the
misc/improve-is-room-alias-format-valid
branch
from
8b6d2ee to
08bf5ae
Compare
stefanceriu
approved these changes
Nov 8, 2024
|
I think the id parsing checks were kept very 'light' for compatibility reasons, but I might be wrong. The only validation that seems to do anything besides checking the prefix seems to be user_id. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this only used the Ruma checks, which only handled the initial
#char and the domain part. With these changes, the name part is also validated, checking it's lowercase, with no whitespaces and containing only allowed chars, similar to whatDisplayName::to_room_alias_namedoes.Signed-off-by: