fix(ffi): match the right status code in Client::is_room_alias_available

[jmartinesp]

Previously I was matching a different error state, so it turns out the code was failing 🫠 .

• Public API changes documented in changelogs (optional)

Signed-off-by:

[codecov]

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.86%. Comparing base (46232ee) to head (a273022).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/matrix-sdk/src/test_utils/mocks.rs	75.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4235      +/-   ##
==========================================
- Coverage   84.89%   84.86%   -0.03%     
==========================================
  Files         274      274              
  Lines       29689    29712      +23     
==========================================
+ Hits        25204    25215      +11     
- Misses       4485     4497      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[poljar]

How come we don't need to change a test? Could it be that we don't have one? 😨

Anyways, would be nice to add it now.

[jmartinesp]

Will FFI layer tests run in the CI? If so, I'll add one, I thought they didn't 🫤 .

[poljar]

Will FFI layer tests run in the CI? If so, I'll add one, I thought they didn't 🫤 .

Doesn't seem like it.

I think that we should either enable them or move the bulk of the logic to the main crate and add a test there. Fixing a bug without a test sounds worse to me.

[jmartinesp]

Moved the fn to the SDK crate and added some tests, now the FFI layer only maps some values and calls the inner function.

[poljar]

Nice, thanks for adding the test.

Small reminder, please use the MatrixMockServer for new tests in the future.

[jmartinesp]

I implemented a new endpoint in MatrixMockServer for this, I'll merge the PR as soon as the CI is finished.