-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a higher level DisplayName
struct which helps to protect against impersonation via display names
#4237
Conversation
f3a80cb
to
e7b7844
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4237 +/- ##
==========================================
+ Coverage 85.01% 85.03% +0.01%
==========================================
Files 274 274
Lines 30043 30107 +64
==========================================
+ Hits 25542 25602 +60
- Misses 4501 4505 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
It seems like Rust doesn't like the way the lazy regexes are implemented though. |
Yeah, though we don't mutate things but I'll see how to implement this without any compiler complaints. |
5b5d6d4
to
0ef6dac
Compare
a9a2bff
to
62c7405
Compare
@dkasak are you happy now with the PR? Can this be approved? |
This patch introduces a struct that normalizes and sanitizes display names. Display names can be a source of abuse and can contain characters which might make it hard to distinguish one display name from the other. This struct attempts to make it easier to protect against such abuse. Changelog: Introduce a DisplayName struct which normalizes and sanitizes display names. Co-authored-by: Denis Kasak <[email protected]>
1391e09
to
2e122f4
Compare
No description provided.