Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sliding_sync): Add m.room.join_rules to the required state #4239

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jmartinesp
Copy link
Contributor

We need the join rules state event to prevent the SDK from assuming a room with an unknown (as in, not loaded) join rule is public.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@jmartinesp jmartinesp requested a review from a team as a code owner November 8, 2024 15:27
@jmartinesp jmartinesp requested review from Hywan and removed request for a team November 8, 2024 15:27
@jmartinesp jmartinesp enabled auto-merge (rebase) November 8, 2024 15:32
We need the join rules state event to prevent the SDK from assuming a room with an unknown (as in, not loaded) join rule is public.
@jmartinesp jmartinesp force-pushed the feat/add-room-join-rules-to-required-state branch from 6c44d32 to 460c04c Compare November 8, 2024 15:50
@jmartinesp jmartinesp merged commit 204e6e4 into main Nov 8, 2024
40 checks passed
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.90%. Comparing base (b8a61cf) to head (460c04c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4239      +/-   ##
==========================================
+ Coverage   84.87%   84.90%   +0.02%     
==========================================
  Files         274      274              
  Lines       29719    29719              
==========================================
+ Hits        25225    25233       +8     
+ Misses       4494     4486       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp deleted the feat/add-room-join-rules-to-required-state branch November 8, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants