Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(room_alias): Add create_room_alias function #4245

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

jmartinesp
Copy link
Contributor

This associates a room alias with an existing room through its room id.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@jmartinesp jmartinesp requested a review from a team as a code owner November 11, 2024 12:11
@jmartinesp jmartinesp requested review from stefanceriu and removed request for a team November 11, 2024 12:11
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! 👌

@jmartinesp jmartinesp enabled auto-merge (rebase) November 11, 2024 12:19
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (204e6e4) to head (b9e31fd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4245      +/-   ##
==========================================
+ Coverage   84.87%   84.89%   +0.01%     
==========================================
  Files         274      274              
  Lines       29719    29729      +10     
==========================================
+ Hits        25225    25238      +13     
+ Misses       4494     4491       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp merged commit 57e78dd into main Nov 11, 2024
40 checks passed
@jmartinesp jmartinesp deleted the feat/add-create-room-alias-function branch November 11, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants