refactor(ffi): remove duplicated fields in media event contents #4250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4250 +/- ##
==========================================
+ Coverage 84.91% 84.94% +0.03%
==========================================
Files 274 274
Lines 29768 29768
==========================================
+ Hits 25278 25287 +9
+ Misses 4490 4481 -9 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Nov 12, 2024
bindings/matrix-sdk-ffi/src/ruma.rs
Outdated
| @@ -262,6 +262,23 @@ pub enum MessageType { | |||
| Other { msgtype: String, body: String }, | |||
| } | |||
|
|
|||
| /// From MSC2530: https://github.com/tulir/matrix-spec-proposals/blob/body-as-caption/proposals/2530-body-as-caption.md | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Good catch! was copied from a place which used it, so I updated both :)
The caption and filenames were weirdly duplicated in each media content, when the expected behavior is well defined: - if there's both a caption and a filename, body := caption, filename is its own field. - if there's only a filename, body := filename. We can remove all duplicated fields, knowing this, and reconstruct the body based on that information. This should make it clearer to FFI users which is what, and provide a clearer API when creating the caption and so on.
bnjbvr
force-pushed
the
bnjbvr/ffi-refactor-media-event-content
branch
from
77ebb88 to
ae006dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caption and filenames were weirdly duplicated in each media content, when the expected behavior is well defined:
We can remove all duplicated fields, knowing this, and reconstruct the body based on that information. This should make it clearer to FFI users which is what, and provide a clearer API when creating the caption and so on.