feat(utd_hook): Report historical expected UTD with new reason #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4275 +/- ##
==========================================
- Coverage 85.05% 85.05% -0.01%
==========================================
Files 276 276
Lines 30371 30382 +11
==========================================
+ Hits 25833 25842 +9
- Misses 4538 4540 +2 ☔ View full report in Codecov by Sentry. |
BillCarsonFr
requested review from
Hywan and
richvdh
and removed request for
a team
BillCarsonFr
force-pushed
the
valere/utd_hook_historical_message
branch
3 times, most recently
from
23fa445 to
31f91d9
Compare
richvdh
requested changes
Nov 20, 2024
richvdh
requested changes
Nov 20, 2024
richvdh
requested changes
Nov 26, 2024
richvdh
approved these changes
Nov 27, 2024
This PR introduces a new variant to `UtdCause` specifically for device-historical messages (`HistoricalMessage`). These messages cannot be decrypted if key storage is inaccessible. Applications can leverage this new variant to provide more informative error messages to users.
BillCarsonFr
force-pushed
the
valere/utd_hook_historical_message
branch
from
6c62de7 to
a0c86d9
Compare
1 task
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-meta#2581
Detect and report expected historical UTDs as such. Must be integrated by clients and reported with this code in Analytics.
To determine if an event is device historical (i.e sent before the current login existed) we use an heuristic based on the event
origin_server_tsand the device creation local timestamp.Signed-off-by: