-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(room_preview): Add heroes and compute display name #4289
feat(room_preview): Add heroes and compute display name #4289
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4289 +/- ##
==========================================
+ Coverage 85.02% 85.04% +0.02%
==========================================
Files 274 274
Lines 30107 30114 +7
==========================================
+ Hits 25599 25611 +12
+ Misses 4508 4503 -5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This works on iOS! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem sensible, but those changelog entries are a bit terse.
Remember that the category, the thing inside the brackets, room_preview
will be gone once we generate the changelog. So the entry will look like:
- Add heroes for known rooms
- Compute display name
And people will be left wondering what this is about.
Oh, I didn't know that! Yeah, I'll tweak the commit messages then 😅 . |
27f4989
to
0705b88
Compare
You can check out what will be generated using the |
This is needed to fully replace the
invited_room
API with theRoomPreview
one.Signed-off-by: