Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'conn_id' field to sync_once span #4290

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

erikjohnston
Copy link
Member

This is to make it easier to see which sync requests are for which connection when debugging.

This is to make it easier to see which sync requests are for which
connection when debugging.
@erikjohnston erikjohnston requested a review from a team as a code owner November 19, 2024 10:31
@erikjohnston erikjohnston requested review from jmartinesp and removed request for a team November 19, 2024 10:31
@jmartinesp jmartinesp enabled auto-merge (rebase) November 19, 2024 10:34
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.02%. Comparing base (05505a5) to head (ef8e3a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4290   +/-   ##
=======================================
  Coverage   85.01%   85.02%           
=======================================
  Files         274      274           
  Lines       30043    30043           
=======================================
+ Hits        25542    25543    +1     
+ Misses       4501     4500    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jmartinesp jmartinesp merged commit 22bbe0c into main Nov 19, 2024
40 checks passed
@jmartinesp jmartinesp deleted the erikj/ss_conn_id_span branch November 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants