Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(send queue): when adding a local reaction, look for media events in dependent requests too #4294

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Nov 19, 2024

This allows reacting to a local media upload.

Adding a reaction to a local echo would check that the target of the reaction (identified by its transaction id) is part of the requests, but not part of the dependent requests. For a media upload, it's more likely the media event will be alive as a dependent request of kind FinishUpload, so we need to check there too. With that fix, it's then possible to react to a local media upload.

Part of #4201.

@bnjbvr bnjbvr requested a review from a team as a code owner November 19, 2024 14:53
@bnjbvr bnjbvr requested review from stefanceriu and removed request for a team November 19, 2024 14:53
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.13%. Comparing base (f20401c) to head (8abb51f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk-base/src/store/send_queue.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4294      +/-   ##
==========================================
- Coverage   85.15%   85.13%   -0.02%     
==========================================
  Files         274      274              
  Lines       30139    30147       +8     
==========================================
+ Hits        25665    25667       +2     
- Misses       4474     4480       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh super nice, makes perfect sense to me! 👍

@bnjbvr bnjbvr force-pushed the bnjbvr/react-to-local-media-echoes branch from 003a45b to 8abb51f Compare November 19, 2024 16:07
@bnjbvr bnjbvr enabled auto-merge (rebase) November 19, 2024 16:08
@bnjbvr bnjbvr merged commit 8a6ced0 into main Nov 19, 2024
40 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/react-to-local-media-echoes branch November 19, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants