Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base): Add EventCacheStore::handle_linked_chunk_updates #4299

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat(base): Add EventCacheStore::handle_linked_chunk_updates #4299

merged 1 commit into from
Nov 20, 2024

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Nov 20, 2024

This patch adds the handle_linked_chunk_updates method on the EventCacheStore trait.

@Hywan Hywan requested a review from a team as a code owner November 20, 2024 14:12
@Hywan Hywan requested review from bnjbvr and removed request for a team November 20, 2024 14:12
@Hywan Hywan mentioned this pull request Nov 20, 2024
Open
37 tasks
@Hywan Hywan force-pushed the feat-event-cache-store-handle-linked-chunk-update branch from 67ff82e to c73630f Compare November 20, 2024 14:22
bnjbvr
bnjbvr approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay for parallelization \o/

crates/matrix-sdk-base/src/event_cache/store/traits.rs Show resolved Hide resolved
@Hywan Hywan force-pushed the feat-event-cache-store-handle-linked-chunk-update branch from c73630f to 2d9cb54 Compare November 20, 2024 14:37
@Hywan
feat(base): Add EventCacheStore::handle_linked_chunk_updates.
295a3f2 
This patch adds the `handle_linked_chunk_updates` method on the
`EventCacheStore` trait. Part of
matrix-org#3280.
@Hywan Hywan force-pushed the feat-event-cache-store-handle-linked-chunk-update branch from 2d9cb54 to 295a3f2 Compare November 20, 2024 14:48
@Hywan Hywan enabled auto-merge (rebase) November 20, 2024 15:04
@Hywan Hywan mentioned this pull request Nov 20, 2024
Merged
@Hywan Hywan disabled auto-merge November 20, 2024 15:21
@Hywan Hywan enabled auto-merge (rebase) November 20, 2024 15:32
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.18%. Comparing base (8a6ced0) to head (295a3f2).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...es/matrix-sdk-base/src/event_cache/store/traits.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4299   +/-   ##
=======================================
  Coverage   85.17%   85.18%           
=======================================
  Files         274      274           
  Lines       30147    30148    +1     
=======================================
+ Hits        25679    25682    +3     
+ Misses       4468     4466    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@Hywan Hywan merged commit e5ca44b into matrix-org:main Nov 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjbvr bnjbvr bnjbvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hywan @bnjbvr