feat(timeline): mark media events as editable #4303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4303 +/- ##
==========================================
- Coverage 85.09% 85.08% -0.02%
==========================================
Files 274 274
Lines 30183 30184 +1
==========================================
- Hits 25684 25681 -3
- Misses 4499 4503 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
bmarty
reviewed
Nov 20, 2024
| | MessageType::File(_) | ||
| | MessageType::Image(_) | ||
| | MessageType::Video(_) | ||
| ) |
There was a problem hiding this comment.
I see a bit below a function is_highlighted. I am curious, are you using it on iOS?
There was a problem hiding this comment.
I can't find anything - I don't think it has been exposed over the FFI even if we wanted to (but presumably we're happy with the pill colour to highlight a message?).
bnjbvr
approved these changes
Nov 21, 2024
bnjbvr
changed the title
bmarty
added a commit
to element-hq/element-x-android
that referenced
this pull request
Nov 21, 2024
Need matrix-org/matrix-rust-sdk#4303 to work but not to compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes audio, file, image and video messages be editable so that the timeline signals when it is possible to use #4277/#4300 for editing captions.