Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing changelog entries for the ui crate #4312

Closed
wants to merge 1 commit into from

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Nov 22, 2024

No description provided.

@poljar poljar requested a review from a team as a code owner November 22, 2024 17:22
@poljar poljar requested review from Hywan and removed request for a team November 22, 2024 17:22
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (48fbda8) to head (147be55).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4312      +/-   ##
==========================================
- Coverage   85.13%   85.07%   -0.06%     
==========================================
  Files         274      274              
  Lines       30190    30190              
==========================================
- Hits        25701    25683      -18     
- Misses       4489     4507      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@poljar
Copy link
Contributor Author

poljar commented Nov 25, 2024

@bnjbvr mentions that there are a bunch of entries that are not related to the UI crate.

I think we might need to rethink how we do changelogs a bit more, i.e. perhaps switch to a single changelog file with separate categories per crate instead.

@poljar poljar closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants