feat(common): Implement LinkedChunk::clear
#4317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
feat-common-linked-chunk-reset
branch
from
3497c7e to
848451f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4317 +/- ##
==========================================
- Coverage 85.10% 85.06% -0.04%
==========================================
Files 274 274
Lines 30203 30213 +10
==========================================
- Hits 25703 25700 -3
- Misses 4500 4513 +13 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
bnjbvr
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Thanks! Do you also want to have RoomEvents::reset make use of this function in this PR, or in a different one? (it would require a new test that when subscribing to updates_as_vec of the underlying linked chunk, the subscription stream doesn't shut down when RoomEvents::reset() is called)
|
It's purposely on another PR, not yet submitted to avoid PR stacking :-). |
Hywan
force-pushed
the
feat-common-linked-chunk-reset
branch
from
848451f to
31fc3b3
Compare
This patch implements `LinkedChunk::clear`. The code from `impl Drop for LinkedChunk` has been moved inside `Ends::clear`, and replaced by a simple `self.links.clear()`. In addition, `LinkedChunk::clear` indeed calls `self.links.clear()` but also resets all fields. This patch adds the `Clear` variant to `Update`. This patch updates `AsVector` to emit a `VectorDiff::Clear` on `Update::Clear`. Finally, this patch adds the necessary tests.
Hywan
force-pushed
the
feat-common-linked-chunk-reset
branch
from
31fc3b3 to
84a8355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements
LinkedChunk::clear. The code fromimpl Drop for LinkedChunkhas been moved insideEnds::clear, and replaced by a simpleself.links.clear(). In addition,LinkedChunk::clearindeed callsself.links.clear()but also resets all fields.This patch adds the
Clearvariant toUpdate.This patch updates
AsVectorto emit aVectorDiff::ClearonUpdate::Clear.Finally, this patch adds the necessary tests.
EventCachestorage #3280