fix(common): LinkedChunk emits an Update::NewItemsChunk when constructed
#4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructed. This patch updates `LinkedChunk::new_with_update_history` to emit an `Update::NewItemsChunk` because the first chunk is created and it must emit an update accordingly.
Hywan
changed the title
LinkedChunk emits an Update::NewItemsChunk when constuctedLinkedChunk emits an Update::NewItemsChunk when constructed
Hywan
requested review from
jmartinesp and
bnjbvr
and removed request for
a team and
jmartinesp
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4327 +/- ##
==========================================
+ Coverage 85.05% 85.11% +0.05%
==========================================
Files 275 275
Lines 30309 30315 +6
==========================================
+ Hits 25780 25802 +22
+ Misses 4529 4513 -16 ☔ View full report in Codecov by Sentry. |
bnjbvr
approved these changes
Nov 27, 2024
| #[test] | ||
| fn test_push_items() { | ||
| use super::Update::*; | ||
|
|
||
| let mut linked_chunk = LinkedChunk::<3, char, ()>::new_with_update_history(); | ||
|
|
||
| // Ignore initial update. | ||
| let _ = linked_chunk.updates().unwrap().take(); |
There was a problem hiding this comment.
Maybe we could also check (here and everywhere below) that the initial update is what we expected?
There was a problem hiding this comment.
We have a specific test just for that: it builds a LinkedChunk and test the initial state. It helps to not repeat this for all tests.
There was a problem hiding this comment.
That's the test_new_with_initial_update test, just above this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
LinkedChunk::new_with_update_historyto emit anUpdate::NewItemsChunkbecause the first chunk is created and it must emit an update accordingly.The fix is 9 lines changes, the rest is only test updates.