task(crypto_tests): Re-shape tests for UtdCause #4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
requested review from
jmartinesp and
BillCarsonFr
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4349 +/- ##
==========================================
- Coverage 85.18% 85.16% -0.02%
==========================================
Files 280 280
Lines 30729 30729
==========================================
- Hits 26176 26170 -6
- Misses 4553 4559 +6 ☔ View full report in Codecov by Sentry. |
andybalaam
changed the title
andybalaam
force-pushed
the
andybalaam/utd_cause_tests_refactor
branch
from
778dc5d to
914b7cd
Compare
|
Rebased on top of CI fixes. No changes to my commits except updated their descriptions. |
BillCarsonFr
approved these changes
Dec 2, 2024
…r UnableToDecryptInfos
…rrectly This test was checking that a new device which has access to backups returned an unknown UTD when it was given empty JSON for the event. It was only passing because we currently have incorrect behaviour when backups are enabled. The fix is to make the device old and without access to backups, so that we still consider this UTD unexpected.
andybalaam
force-pushed
the
andybalaam/utd_cause_tests_refactor
branch
from
5db4563 to
0b89ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-meta#2638
If you review commit by commit you will see explanations for what I did, but you will read more code in total.