Simplify exists_on_server tests #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
requested changes
Nov 29, 2024
| @@ -1282,4 +1254,60 @@ mod test { | |||
|
|
|||
| server.verify().await; | |||
| } | |||
|
|
|||
| async fn mock_backup_exists(server: &MockServer) -> MockGuard { | |||
There was a problem hiding this comment.
These should become part of the MatrixMockServer.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4355 +/- ##
==========================================
- Coverage 85.14% 85.11% -0.04%
==========================================
Files 280 280
Lines 30764 30793 +29
==========================================
+ Hits 26193 26208 +15
- Misses 4571 4585 +14 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Dec 3, 2024
andybalaam
force-pushed
the
andybalaam/refactor-exists-on-server-tests
branch
from
6f1588f to
944a1ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of element-hq/element-meta#2638
I am planning to add a
fast_exists_on_servermethod which uses a locally-cached value. This change makes the tests ready so I can re-use parts of them in my tests for the new method.