refactor(ui): Introduce the AllRemoteEvents type
#4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4370 +/- ##
==========================================
- Coverage 85.18% 85.15% -0.03%
==========================================
Files 280 280
Lines 30761 30773 +12
==========================================
+ Hits 26203 26206 +3
- Misses 4558 4567 +9 ☔ View full report in Codecov by Sentry. |
Hywan
changed the title
AllRemoteEvents type
Hywan
force-pushed
the
refactor-ui-timeline-all-remote-events-type
branch
from
904548d to
84bd2e1
Compare
This patch replaces `VecDeque<EventMeta>` by `AllRemoteEvents` which is a wrapper type around `VecDeque<EventMeta>`, but this new type aims at adding semantics API rather than a generic API. It also helps to isolate the use of these values and to know precisely when and how they are used. As a first step, `AllRemoteEvents` implements a generic API to not break the existing code. Next patches will revisit that a little bit step by step.
This patch renames `AllRemoteEvents::back` to `last` so that it now gets a specific semantics instead of being generic.
Having a mutable iterator can be dangerous and is probably too generic regarding the safety we want to add around the `AllRemoteEvents` type. This patch removes `iter_mut` and replaces it by its only use case: `get_by_event_id_mut`.
Hywan
force-pushed
the
refactor-ui-timeline-all-remote-events-type
branch
from
84bd2e1 to
5689a6f
Compare
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A shepherdess gathering a herd of sheep.
Build on top of #4369.
The first patch replaces
VecDeque<EventMeta>byAllRemoteEventswhichis a wrapper type around
VecDeque<EventMeta>, but this new type aimsat adding semantics API rather than a generic API. It also helps to
isolate the use of these values and to know precisely when and how they
are used.
As a first step,
AllRemoteEventsimplements a generic API to not breakthe existing code. Next patches are revisiting that a little bit step
by step:
AllRemoteEvents::backbecomeslastto add semantics.AllRemoteEvents::iter_mutare removed andget_by_event_id_mutis created.
This PR should be reviewed patch-by-patch.
EventCachestorage #3280