Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event cache): don't clear a timeline if storage's enabled #4374

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Dec 3, 2024

This is one of the last steps for integrating the persistent storage: if a timeline is gappy, then we don't need to reset it, either internally or for observers. That's the whole point of persisting the event cache, after all: we should be able to paginate again from any holes we encounter later.

Part of #3280

@bnjbvr bnjbvr mentioned this pull request Dec 3, 2024
37 tasks
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (a4434d7) to head (52e6544).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/event_cache/room/mod.rs 40.00% 3 Missing ⚠️
crates/matrix-sdk/src/event_cache/mod.rs 80.00% 1 Missing ⚠️
crates/matrix-sdk/src/test_utils/mocks.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4374   +/-   ##
=======================================
  Coverage   85.15%   85.16%           
=======================================
  Files         280      280           
  Lines       30826    30831    +5     
=======================================
+ Hits        26251    26256    +5     
  Misses       4575     4575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr force-pushed the bnjbvr/dont-clear-after-limited-timeline-with-storage branch from 4a30797 to 8e78929 Compare December 4, 2024 12:14
@bnjbvr bnjbvr marked this pull request as ready for review December 4, 2024 12:14
@bnjbvr bnjbvr requested a review from a team as a code owner December 4, 2024 12:14
@bnjbvr bnjbvr requested review from stefanceriu and removed request for a team December 4, 2024 12:14
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, makes sense to me and all those test tweaks are the cherry on top 👌

@bnjbvr bnjbvr force-pushed the bnjbvr/dont-clear-after-limited-timeline-with-storage branch from e7dbfe3 to 52e6544 Compare December 4, 2024 16:04
@bnjbvr bnjbvr enabled auto-merge (rebase) December 4, 2024 16:04
@bnjbvr bnjbvr merged commit a6e1f05 into main Dec 4, 2024
40 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/dont-clear-after-limited-timeline-with-storage branch December 4, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants