Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ffi): Add method to send custom events with JSON content #4390

Merged
merged 5 commits into from
Dec 10, 2024
Merged

feat(ffi): Add method to send custom events with JSON content #4390

merged 5 commits into from
Dec 10, 2024

Conversation

jonasrichardrichter
Copy link
Contributor

This PR adds the send_raw methods to the bindings, making it usable from e.g. Swift.

  • Public API changes documented in changelogs (optional)

Signed-off-by: Jonas Richard Richter [email protected]

@jonasrichardrichter jonasrichardrichter requested a review from a team as a code owner December 9, 2024 10:01
@jonasrichardrichter jonasrichardrichter requested review from poljar and removed request for a team December 9, 2024 10:01
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (bf6fa4c) to head (12794bc).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4390   +/-   ##
=======================================
  Coverage   85.15%   85.15%           
=======================================
  Files         280      280           
  Lines       30881    30881           
=======================================
+ Hits        26296    26297    +1     
+ Misses       4585     4584    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

poljar
poljar requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, needs a bit more work but generally looks good.

bindings/matrix-sdk-ffi/src/room.rs Outdated Show resolved Hide resolved
bindings/matrix-sdk-ffi/src/room.rs Outdated Show resolved Hide resolved
bindings/matrix-sdk-ffi/src/room.rs Outdated Show resolved Hide resolved
@jonasrichardrichter
Copy link
Contributor Author

jonasrichardrichter commented Dec 9, 2024 •
edited
Loading

Thanks for your feedback :) These we're my first steps in the Rust space ^^
I've added all the requests you made.

@poljar
Copy link
Contributor

poljar commented Dec 9, 2024

Seems that rustfmt isn't happy with you just yet, you can fix this if you run cargo xtask fixup style.

poljar
poljar approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@poljar poljar merged commit 72fcc50 into matrix-org:main Dec 10, 2024
40 checks passed
@jonasrichardrichter jonasrichardrichter deleted the feature/ffi-add-send-raw branch December 10, 2024 10:03
andybalaam pushed a commit that referenced this pull request Dec 18, 2024
@jonasrichardrichter @andybalaam
feat(ffi): Expose the method to send custom events with JSON content (#…
8d829ff 
…4390)

This patch adds the Room::send_raw method to the bindings, making it usable from
e.g. Swift.

Signed-off-by: Jonas Richard Richter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasrichardrichter @poljar