Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typos configuration #4394

Closed
wants to merge 2 commits into from
Closed

Conversation

szepeviktor
Copy link

Make typos config more strict: miss less future misspellings.

  • Public API changes documented in changelogs (optional)

@szepeviktor szepeviktor requested a review from a team as a code owner December 9, 2024 14:34
@szepeviktor szepeviktor requested review from bnjbvr and removed request for a team December 9, 2024 14:34
# Our json files contain a bunch of base64 encoded ed25519 keys.
"benchmarks/benches/crypto_bench/*.json",
]
ignore-hidden = false
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go into dot files/directories.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.20%. Comparing base (affdc25) to head (87ab8d8).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4394      +/-   ##
==========================================
+ Coverage   85.18%   85.20%   +0.01%     
==========================================
  Files         281      281              
  Lines       30924    30924              
==========================================
+ Hits        26343    26348       +5     
+ Misses       4581     4576       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szepeviktor szepeviktor closed this Dec 9, 2024
@szepeviktor szepeviktor reopened this Dec 9, 2024
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, but I fail to understand what it improves. It will go into the hidden directories, which might be nice or annoying according to the developer who runs into it. It replaces 6 false positives with 5 false positives. Does it do something else that I'm not seeing?

@szepeviktor
Copy link
Author

You are right.
It deserves a "close".

I thought those cryptographic values could be - somehow - ignored in a simple way.

@szepeviktor szepeviktor deleted the typos branch December 10, 2024 15:52
@bnjbvr
Copy link
Member

bnjbvr commented Dec 11, 2024

Thanks for trying to improve the situation though, I appreciate the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants