-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typos configuration #4394
Conversation
# Our json files contain a bunch of base64 encoded ed25519 keys. | ||
"benchmarks/benches/crypto_bench/*.json", | ||
] | ||
ignore-hidden = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go into dot files/directories.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4394 +/- ##
==========================================
+ Coverage 85.18% 85.20% +0.01%
==========================================
Files 281 281
Lines 30924 30924
==========================================
+ Hits 26343 26348 +5
+ Misses 4581 4576 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch, but I fail to understand what it improves. It will go into the hidden directories, which might be nice or annoying according to the developer who runs into it. It replaces 6 false positives with 5 false positives. Does it do something else that I'm not seeing?
You are right. I thought those cryptographic values could be - somehow - ignored in a simple way. |
Thanks for trying to improve the situation though, I appreciate the effort. |
Make typos config more strict: miss less future misspellings.