feat(event cache): add a way to clear all chunks, clear a room's chunks + FFI feature flag #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4396 +/- ##
==========================================
+ Coverage 85.20% 85.22% +0.01%
==========================================
Files 281 281
Lines 30963 30990 +27
==========================================
+ Hits 26383 26410 +27
Misses 4580 4580 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Dec 9, 2024
| @@ -624,6 +645,21 @@ impl ClientBuilder { | |||
|
|
|||
| let sdk_client = inner_builder.build().await?; | |||
|
|
|||
| if let Some(val) = builder.use_event_cache_persistent_storage { | |||
| if val { | |||
| // Enable the persistent storage \o/ | |||
…wkward By default, the event cache store will be disabled. If disabled, it will clean all the events in the cache store; most of the time this will do nothing, since the store will not even be filled with any event data, so it would be cheap to do. If some data was filled in the cache store before, then it would be cleared after the cache store has been disabled. This makes a less awkward API than the previous one, where `None` and `Some(false)` carried different semantics.
bnjbvr
force-pushed
the
bnjbvr/clear-all-chunks
branch
from
8b05176 to
d6c8867
Compare
|
As discussed in private, the last commit changes the semantics so that the feature flag is not optional, and always set to false. It makes it less awkward when used by consumers. (See commit message for details.) |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to:
ClientBuilderto enable or disable persistent storage. Note: after persistent storage has been enabled, if the embedder decides to disable it, they must explicitly set it tofalsethe next time; otherwise the on-disk storage isn't cleared.The last item isn't very satisfying, but I don't see how to do it otherwise without more involved refactorings. The way persistent storage works right now, is by checking the presence of an event cache store reference in the
RoomEventCacheStatedata structure. This is filled at most once, and only once, and never cleared (it's not even clearable). As such, a restart is required for disabling the persistent storage; after restarting is the right time to clear a previous on-disk persisted storage. If we do it sooner than that, then the liveRoomEventCacheStatemay keep on trying to store new updates…Part of #3280.