-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(timeline): Configurable timeline date dividers #4398
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4398 +/- ##
==========================================
- Coverage 85.27% 85.24% -0.04%
==========================================
Files 282 282
Lines 31130 31149 +19
==========================================
+ Hits 26546 26552 +6
- Misses 4584 4597 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; a couple of light suggestions.
Make sure this doesn't get squashed when you merge since the separation you have made between renames and functional changes is really helpful.
…ppear either when the day changes or when the month changes.
…owing the introduction of montly divider mode
df1ca56
to
2f7a0f3
Compare
Expose a timeline configuration option to allow date separators to go in between different days or different months.
The only real logic change is in the first commit in
DateDividerAdjuster::is_same_date_as
where the configuration option is now taken into account.This will work together with the newly added
message_filtered_timeline
to power the Element X media gallery and its sections.This PR also renames all day dividers to date dividers in the last 2 commits.