fix(event cache): fix back-pagination ordering in one specific case #4402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditions required to cause the bug might have been impossible to reach in the real world, because it assumes a mix of: - events present in the linked chunk - no prev-batch token However: now that we have storage, we could end up in this situation, when reaching the start of the timeline (since there'll be no previous gap in that case). We need to handle that better in the linked chunk representation itself, but in the meanwhile, we should insert the gap and the events in a relative correct order.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4402 +/- ##
=======================================
Coverage 85.27% 85.28%
=======================================
Files 282 282
Lines 31209 31211 +2
=======================================
+ Hits 26615 26619 +4
+ Misses 4594 4592 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a refactoring of the event cache's logic for back-paginations, for other purposes, but turns out there was a bug if you were in the following conditions:
In this case, if we ran a back-pagination, the next prev-batch token would be in the wrong position, compared to the events that we just back-paginated. Which means that the next back-pagination would insert events in the wrong place. The integration test I added acts as a regression test, which failed on main.