refactor(state store): use a single lock for all memory store accesses #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MemoryStore` implementation of the `StateStore` has grown into a monster, with one lock per field. It's probably overkill, as individual fields don't need fine-grained locks like this; after all, accesses to the store shouldn't be reentrant in general. Fixes #3720.
bnjbvr
force-pushed
the
bnjbvr/inner-state-memory-store
branch
from
bf7c72d to
e9fd733
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4403 +/- ##
==========================================
- Coverage 85.27% 85.26% -0.02%
==========================================
Files 282 282
Lines 31209 31178 -31
==========================================
- Hits 26615 26584 -31
Misses 4594 4594 ☔ View full report in Codecov by Sentry. |
1 task
stefanceriu
approved these changes
Dec 12, 2024
| /// Default if no other is configured at startup. | ||
| #[derive(Debug, Default)] | ||
| pub struct MemoryStore { | ||
| inner: RwLock<MemoryStoreInner>, |
There was a problem hiding this comment.
Huh, that's all there is to it, very nice 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MemoryStoreimplementation of theStateStorehas grown into a monster, with one lock per field. It's probably overkill, as individual fields don't need fine-grained locks like this; after all, accesses to the store shouldn't be reentrant in general.Also allows us to get rid of some annoying trace logs, which is the reason why I was reminded of this problem.
Fixes #3720.
Let's see how Complement Crypto likes it…