feat(room): Separate RoomState::Ban from RoomState::Left.
#4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
force-pushed
the
feat/separate-banned-room-state-from-left
branch
2 times, most recently
from
184ce24 to
0d2eaf5
Compare
jmartinesp
commented
Dec 13, 2024
Comment on lines
+1931
to
+2027
| if self.contains(Self::KNOCKED) { | ||
| states.push(RoomState::Knocked); | ||
| } |
There was a problem hiding this comment.
Oops, this was never added when the behaviour changed before. I added a test including these 2 new cases.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4414 +/- ##
==========================================
+ Coverage 85.30% 85.31% +0.01%
==========================================
Files 283 283
Lines 31435 31442 +7
==========================================
+ Hits 26815 26826 +11
+ Misses 4620 4616 -4 ☔ View full report in Codecov by Sentry. |
jmartinesp
force-pushed
the
feat/separate-banned-room-state-from-left
branch
2 times, most recently
from
399fe21 to
505e809
Compare
bnjbvr
approved these changes
Dec 16, 2024
| @@ -218,14 +218,14 @@ pub enum RoomState { | |||
| Invited, | |||
| /// The room is in a knocked state. | |||
| Knocked, | |||
| /// The room is in a banned state. | |||
| Ban, | |||
There was a problem hiding this comment.
Can you name this Banned, for consistency with the other states?
This is needed to tell apart rooms in left and banned state in places like `RoomInfo` or `RoomPreview`. The banned rooms will still count as left rooms in the sync processes.
jmartinesp
force-pushed
the
feat/separate-banned-room-state-from-left
branch
from
505e809 to
e33d0db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to tell apart rooms in left and banned state in places like
RoomInfoorRoomPreview.The banned rooms will still count as left rooms in the sync processes.
Signed-off-by: